[lkml]   [2017]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v8 10/11] arm64/kasan: explicitly zero kasan shadow memory
    Hi Mark,

    I had this option  back upto version 3, where zero flag was passed into
    vmemmap_alloc_block(), but I was asked to remove it, because it required
    too many changes in other places. So, the current approach is cleaner,
    but the idea is that kasan should use its own version of
    vmemmap_populate() for both x86 and ARM, but I think it is outside of
    the scope of this work.

    See this comment from Ard Biesheuvel:

    KASAN uses vmemmap_populate as a convenience: kasan has nothing to do
    with vmemmap, but the function already existed and happened to do what
    KASAN requires.

    Given that that will no longer be the case, it would be far better to
    stop using vmemmap_populate altogether, and clone it into a KASAN
    specific version (with an appropriate name) with the zeroing folded
    into it.

    If you think I should add these function in this project, than sure I
    can send a new version with kasanmap_populate() functions.

    Thank you,

    On 09/15/2017 04:38 PM, Mark Rutland wrote:
    > On Thu, Sep 14, 2017 at 09:30:28PM -0400, Pavel Tatashin wrote:
    >> Hi Mark, Thank you for looking at this. We can't do this because page
    >> table is not set until cpu_replace_ttbr1() is called. So, we can't do
    >> memset() on this memory until then.
    > I see. Sorry, I had missed that we were on the temporary tables at
    > this point in time. I'm still not keen on duplicating the iteration.
    > Can we split the vmemmap code so that we have a variant that takes a
    > GFP? That way we could explicitly pass __GFP_ZERO for those cases
    > where we want a zeroed page, and are happy to pay the cost of
    > initialization. Thanks Mark.

     \ /
      Last update: 2017-09-15 23:23    [W:3.186 / U:0.012 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site