lkml.org 
[lkml]   [2017]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + include-linux-sched-mmh-uninline-mmdrop_async-etc.patch added to -mm tree
On Fri 15-09-17 09:07:31, Michal Hocko wrote:
> On Thu 14-09-17 13:19:38, Andrew Morton wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Subject: include/linux/sched/mm.h: uninline mmdrop_async(), etc
> >
> > mmdrop_async() is only used in fork.c. Move that and its support
> > functions into fork.c, uninline it all.
>
> Is this really an improvement? Why do we want to discourage more code
> paths to use mmdrop_async? It sounds like a useful api and it has been
> removed only because it lost its own user in oom code. Now that we have
> a user I would just keep it where it was before.

Dohh, I have mixed mmput_async with mmdrop_async. Anyway I still think
that this is universal enough to have it in a header rather than hiding
it in fork.c
--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2017-09-15 09:13    [W:0.035 / U:1.728 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site