lkml.org 
[lkml]   [2017]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: usb/gadget: stalls in dummy_timer
On Thu, 14 Sep 2017, Andrey Konovalov wrote:

> On Thu, Sep 14, 2017 at 7:49 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
> > On Thu, 14 Sep 2017, Andrey Konovalov wrote:
> >
> >> Looked at this a little more.
> >>
> >> dummy_timer() stucks in an infinite loop. It calls
> >> usb_hcd_giveback_urb(), which in turn calls usbtouch_irq(), which
> >> calls usb_submit_urb(), which calls dummy_urb_enqueue() and puts urb
> >> back into dummy urb queue. dummy_timer() then does goto restart, finds
> >> the urb and calls usb_hcd_giveback_urb() again. And this process goes
> >> on again and again. It seems that something should either process the
> >> urb and set urb->status or it should just expire.
> >
> > There is some throttling code, but it applies only to bulk transfers.
> > Probably because the bandwidth limits for other types are slightly
> > different. However, I don't think we need to worry about this level of
> > detail, since the driver makes a number of other approximations anyway.
> >
> > Try the patch below; it should fix the problem.
>
> Hi Alan,
>
> Just tried your patch, my reproducer still hangs the kernel until all
> memory is exhausted.
>
> Thanks!

Hmmm. Your reproducer doesn't run on my system. The mmap system call
fails, perhaps because this laptop has a 32-bit kernel. So I can't
tell what's going on.

Can you collect a usbmon trace that shows what happens while the
reproducer runs? If it turns out to be extremely large, just post an
initial portion of it.

Alan Stern

\
 
 \ /
  Last update: 2017-09-15 20:58    [W:0.065 / U:0.172 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site