lkml.org 
[lkml]   [2017]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/12] x86/crypto: Fix RBP usage in several crypto .S files

* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> > So if this observation of mine is true we could go back to the old code for the
> > hotpath, but use RDI for TBL and not reload it in the hotpath.
>
> Thanks for the excellent breakdown.
>
> When I looked at the patch again, I came to the same conclusion as your
> #4, which is that RDI isn't being used in the inner loops. It *is* used
> in the outermost loop, however.
>
> So v2 of my sha512-avx2-asm.S patch spilled CTX onto the stack, instead
> of TBL:
>
> https://lkml.kernel.org/r/20170913223303.pskmy2v7nto6rvtg@treble

Indeed - I should have checked your v2 patch, but somehow missed it. Would have
saved me some looking+typing ;-)

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-09-15 07:37    [W:0.065 / U:0.992 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site