lkml.org 
[lkml]   [2017]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum
Date
Hi Ricardo,

Thank you for the patch.

On Wednesday, 13 September 2017 10:35:52 EEST Ricardo Ribalda Delgado wrote:
> max_width and max_height are swap with step_width and step_height.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>
> Since that this bug has been here for ever. I do not know if we should
> notify stable or not
>
> I have also cut the lines to respect the 80 char limit
>
> v2: Suggested by Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> -Fix indentation
>
> drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
> b/drivers/media/v4l2-core/v4l2-ioctl.c index b60a6b0841d1..0292f327467d
> 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -730,9 +730,9 @@ static void v4l_print_frmsizeenum(const void *arg, bool
> write_only) break;
> case V4L2_FRMSIZE_TYPE_STEPWISE:
> pr_cont(", min=%ux%u, max=%ux%u, step=%ux%u\n",
> - p->stepwise.min_width, p->stepwise.min_height,
> - p->stepwise.step_width, p->stepwise.step_height,
> - p->stepwise.max_width, p->stepwise.max_height);
> + p->stepwise.min_width, p->stepwise.min_height,
> + p->stepwise.max_width, p->stepwise.max_height,
> + p->stepwise.step_width, p->stepwise.step_height);
> break;
> case V4L2_FRMSIZE_TYPE_CONTINUOUS:
> /* fall through */


--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2017-09-15 03:55    [W:0.231 / U:4.244 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site