[lkml]   [2017]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer
On 09/14/2017 09:38 PM, David Lin wrote:
> On Thu, Sep 14, 2017 at 12:31 PM, Jacek Anaszewski
> <> wrote:
>> I would change one more thing in this patch, though. The hr_timer engine
>> should be made optional and not used by default for fast LEDs.
>> It could be made configurable by exposing additional sysfs file from
>> ledtrig-transient.c, e.g. hr_timer_support, accepting boolean value.
> Do you mean in additional to checking the LED_BRIGHTNESS_FAST flag,
> userspace has to explicitly enable it via sysfs for ledtrig to select
> hrtimer? This seems to be redundant to me. Could you please explain
> your concerns and the benefit of doing this? Thanks.

My concern is that fast LED users would be automatically
imposed a hr_timer overhead, which they may not need.

Best regards,
Jacek Anaszewski

 \ /
  Last update: 2017-09-14 22:04    [W:0.107 / U:9.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site