lkml.org 
[lkml]   [2017]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] selftests/intel_pstate: No need to compile test progs in the run script
From
Date
On 09/08/2017 06:01 AM, Thomas Meyer wrote:
> Both test programs are being compiled by make, so no need to compile both
> programs in the runner script.
> This resolves an error when installing all selftests via make install
> and run them in a different environemnt.
>
> Running tests in intel_pstate
> ========================================
> ./run.sh: line 35: gcc: command not found
> Problem compiling aperf.c.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> tools/testing/selftests/intel_pstate/run.sh | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> index 7868c106b8b1..96878e44f465 100755
> --- a/tools/testing/selftests/intel_pstate/run.sh
> +++ b/tools/testing/selftests/intel_pstate/run.sh
> @@ -31,12 +31,6 @@ EVALUATE_ONLY=0
>
> max_cpus=$(($(nproc)-1))
>
> -# compile programs
> -gcc aperf.c -Wall -D_GNU_SOURCE -o aperf -lm
> -[ $? -ne 0 ] && echo "Problem compiling aperf.c." && exit 1
> -gcc -o msr msr.c -lm
> -[ $? -ne 0 ] && echo "Problem compiling msr.c." && exit 1
> -
> function run_test () {
>
> file_ext=$1
>
Thanks for the patch. I will get this into 4.14-rc2 or rc3

thanks,
-- Shuah

\
 
 \ /
  Last update: 2017-09-14 19:29    [W:0.073 / U:4.200 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site