lkml.org 
[lkml]   [2017]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping
On Thu, Sep 14, 2017 at 2:42 AM, John Ogness <john.ogness@linutronix.de> wrote:
> Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in
> /proc/PID/stat") stopped reporting eip/esp because it is
> racey and dangerous for executing tasks. The comment adds:
>
> As far as I know, there are no use programs that make any
> material use of these fields, so just get rid of them.
>
> However, existing userspace core-dump-handler applications (for
> example, minicoredumper) are using these fields since they
> provide an excellent cross-platform interface to these valuable
> pointers. So that commit introduced a user space visible
> regression.
>
> Partially revert the change and make the readout possible for
> tasks with the proper permissions and only if the target task
> has the PF_DUMPCORE flag set.

Looks okay to me.

Reviewed-by: Andy Lutomirski <luto@kernel.org>

--Andy

\
 
 \ /
  Last update: 2017-09-14 19:29    [W:0.067 / U:10.600 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site