lkml.org 
[lkml]   [2017]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob
From
Date


> On 2017年9月13日, at 下午9:02, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote:
>> On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote:
>>> Different namespace application might require enable TCP Fast Open
>>> feature independently of the host.
>>>
>>
>> Poor changelog, no actual description / list of sysctls that are moved
>> to per netns.
>>
>> And looking at the patch, it seems your conversion is not complete.
>>
>> So I will ask you to provide more evidence that you tested your patch
>> next time you submit it.
>
> I suggest you move one sysctl at a time, in a patch series.
>
> It will be easier to document and test for you, and review for us.
>
> Thanks.
>

Okay, I will split my patch for each sysctl change. Thanks.



\
 
 \ /
  Last update: 2017-09-14 08:19    [W:0.037 / U:0.132 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site