lkml.org 
[lkml]   [2017]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 09/11] selftests: lib.mk: copy test scripts and test files for make O=dir run
    Date


    > -----Original Message-----
    > From: Shuah Khan on Tuesday, September 12, 2017 4:53 PM
    >
    > For make O=dir run_tests to work, test scripts, test files, and other
    > dependencies need to be copied over to the object directory. Running
    > tests from the object directory is necessary to avoid making the source
    > tree dirty.
    >
    > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
    > ---
    > tools/testing/selftests/lib.mk | 11 +++++++++++
    > 1 file changed, 11 insertions(+)
    >
    > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
    > index 2e13cabb8007..9aa820d35c0c 100644
    > --- a/tools/testing/selftests/lib.mk
    > +++ b/tools/testing/selftests/lib.mk
    > @@ -37,7 +37,18 @@ define RUN_TESTS
    > endef
    >
    > run_tests: all
    > +ifneq ($(KBUILD_SRC),)
    > + @if [ "X$(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)" !=
    > "X" ]; then
    > + @rsync -aq $(TEST_PROGS) $(TEST_PROGS_EXTENDED)
    > $(TEST_FILES) $(OUTPUT)

    rsync seems a bit heavy-handed for this. Is there a reason to use
    rsync vs. just a regular cp? Does the existing kbuild system already
    have a dependency on rsync? If not, I don't think we should introduce one
    here.

    BTW - great work!

    > + fi
    > + @if [ "X$(TEST_PROGS)" != "X" ]; then
    > + $(call RUN_TESTS, $(TEST_GEN_PROGS)
    > $(TEST_CUSTOM_PROGS) $(OUTPUT)/$(TEST_PROGS))
    > + else
    > + $(call RUN_TESTS, $(TEST_GEN_PROGS)
    > $(TEST_CUSTOM_PROGS))
    > + fi
    > +else
    > $(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS)
    > $(TEST_PROGS))
    > +endif
    >
    > define INSTALL_RULE
    > @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" !=
    > "X" ]; then \
    > --
    > 2.11.0
    >

    \
     
     \ /
      Last update: 2017-09-13 20:14    [W:4.692 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site