lkml.org 
[lkml]   [2017]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case
On Wed, 13 Sep 2017, Dmitry Torokhov wrote:

> > > From: Adrian Salido <salidoa@google.com>
> > >
> > > The buffer allocation is not currently accounting for an extra byte for
> > > the report id. This can cause an out of bounds access in function
> > > i2c_hid_set_or_send_report() with reportID > 15.
> > >
> > > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >
> > Missing signoff from the patch author?
>
> Oops, I must have cut it off on accident while removing ChromeOS
> specific tags, the original commit is here:
>
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212

Ok, thanks, will use that one. How about

Reviewed-by: Benson Leung <bleung@chromium.org>

which is missing in the mail you've sent, but is there in the above
reference commit?

> > Also, I think this should have Cc: stable, right?
>
> I usually let maintainers decide, but yes.

I'll be adding it. Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2017-09-13 16:53    [W:0.069 / U:2.484 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site