lkml.org 
[lkml]   [2017]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case
On Wed, Sep 13, 2017 at 07:02:05AM -0700, Jiri Kosina wrote:
> On Fri, 8 Sep 2017, Dmitry Torokhov wrote:
>
> > From: Adrian Salido <salidoa@google.com>
> >
> > The buffer allocation is not currently accounting for an extra byte for
> > the report id. This can cause an out of bounds access in function
> > i2c_hid_set_or_send_report() with reportID > 15.
> >
> > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Missing signoff from the patch author?

Oops, I must have cut it off on accident while removing ChromeOS
specific tags, the original commit is here:

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212

>
> Also, I think this should have Cc: stable, right?

I usually let maintainers decide, but yes.

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2017-09-13 16:51    [W:0.161 / U:1.240 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site