Messages in this thread | | | Date | Wed, 13 Sep 2017 13:18:43 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH] mm/memblock.c: make the index explicit argument of for_each_memblock_type |
| |
On Wed 13-09-17 13:05:02, Gi-Oh Kim wrote: > On Wed, Sep 13, 2017 at 12:55 PM, Michal Hocko <mhocko@kernel.org> wrote: > > On Wed 13-09-17 11:06:06, Gioh Kim wrote: > >> for_each_memblock_type macro function uses idx variable that is > >> the local variable of caller. This patch makes for_each_memblock_type > >> use only its own arguments. > > > > strictly speaking this changelog doesn't explain _why_ the original code > > is wrong/suboptimal and why you are changing that. I would use the > > folloging > > > > " > > for_each_memblock_type macro function relies on idx variable defined in > > the caller context. Silent macro arguments are almost always wrong thing > > to do. They make code harder to read and easier to get wrong. Let's > > use an explicit iterator parameter for for_each_memblock_type and make > > the code more obious. This patch is a mere cleanup and it shouldn't > > introduce any functional change. > > " > > Absolutely this changelog is better. > Should I send the patch with your changelog again? > Or could you just replace my changelog with yours?
Please repost and make sure to CC Andrew Morton so that he can take the patch. -- Michal Hocko SUSE Labs
| |