lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] procfs: remove unused variable
On Mon 11-09-17 22:02:16, Arnd Bergmann wrote:
> in NOMMU configurations, we get a warning about a variable
> that has become unused:
>
> fs/proc/task_nommu.c: In function 'nommu_vma_show':
> fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]
>
> Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")

this sha doesn't exist in Linus tree. I guess it comes from linux-next.
The merged commit is 1240ea0dc3bb ("fs, proc: remove priv argument from
is_stack")

Other than that
Acked-by: Michal Hocko <mhocko@suse.com>

Thanks for catching this and the fix!

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/proc/task_nommu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
> index dea90b566a6e..b00b766098fa 100644
> --- a/fs/proc/task_nommu.c
> +++ b/fs/proc/task_nommu.c
> @@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
> int is_pid)
> {
> struct mm_struct *mm = vma->vm_mm;
> - struct proc_maps_private *priv = m->private;
> unsigned long ino = 0;
> struct file *file;
> dev_t dev = 0;
> --
> 2.9.0
>

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2017-09-12 09:44    [W:0.033 / U:97.752 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site