lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support
On Tue, Sep 05, 2017 at 06:42:20PM +0200, Hans de Goede wrote:
> Add mux support to the fusb302 driver, call devm_tcpc_gen_mux_create()
> to let the generic tcpc_mux_dev code create a tcpc_mux_dev for us.
>
> Also document the mux-names used by the generic tcpc_mux_dev code in
> our devicetree bindings.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 3 +++
> drivers/staging/typec/fusb302/fusb302.c | 11 ++++++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
> index 472facfa5a71..63d639eadacd 100644
> --- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
> +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
> @@ -6,6 +6,9 @@ Required properties :
> - interrupts : Interrupt specifier
>
> Optional properties :
> +- mux-controls : List of mux-ctrl-specifiers containing 1 or 2 muxes
> +- mux-names : "type-c-mode-mux" when using 1 mux, or
> + "type-c-mode-mux", "usb-role-mux" when using 2 muxes

I'm not sure this is the right place for this. The mux is outside the
FUSB302. In a type-C connector node or USB phy node would make more
sense to me.

> - fcs,max-sink-microvolt : Maximum voltage to negotiate when configured as sink
> - fcs,max-sink-microamp : Maximum current to negotiate when configured as sink
> - fcs,max-sink-microwatt : Maximum power to negotiate when configured as sink

\
 
 \ /
  Last update: 2017-09-13 00:21    [W:0.142 / U:10.464 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site