lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest
From
Date


On 09/12/2017 03:04 PM, Borislav Petkov wrote:
...

>> SEV-enabled guest is from 1 to a maximum value defined via CPUID
>> Fn8000_001f[ECX].
>
> I'd rewrite that to:
>
> "The range of allowed SEV guest ASIDs is [1 - CPUID_8000_001F[ECX][31:0]]".
>

thanks, will do.

...

>>
>> +/* Secure Encrypted Virtualization */
>
> If anything, this comment should explain what that variable is.
> Basically the comment you have in sev_hardware_setup() now.
>

Will add more comments.

...

>
> max_sev_asid is static and it is already initialized to 0 and thus this
> function can be simplified to:
>
> /*
> * Get maximum number of encrypted guest supported: Fn8001_001F[ECX].
> * [31:0]: Number of supported guests.
> */
> static __init void sev_hardware_setup(void)
> {
> max_sev_asid = cpuid_ecx(0x8000001F);
> }
>

Agreed, I will improve it.

thanks

\
 
 \ /
  Last update: 2017-09-12 22:25    [W:0.137 / U:3.932 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site