lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard commands
On 09/12, Daeho Jeong wrote:
> > Yeah, that's exactly like what I made a mistake before.
> > I should have mentioned that earlier. :)
>
> Or I think the previous code which used "iter++" might be right.
> You might just want to check the fixed number of small discards, DISCARD_ISSUE_RATE,
> when issue_cond is "true".
>
> Anyways, I have another question about this function.
> How about just issuing, not checking whether it is idle, the fixed number of small
> discards, DISCARD_ISSUE_RATE, when issue_cond is "true".
> Actually, the discard commands will be issued as "asynchronous" requests,
> which has a low priority in the I/O scheduler,
> so the performance degradation of other threads by doing this will not be much severe,
> but we can make the performance of the storage device better even if there is no idle.

I don't think I/O scheduler can efficiently prioritize discard commands and user
requests. The proper way that we can do would be waiting for idle time at this
moment.

Thanks,

>
> I am just worried about the storage device I/O performance gets worse
> under I/O intensive senario where there is no idle
>
> Thanks,

\
 
 \ /
  Last update: 2017-09-12 19:13    [W:0.131 / U:0.392 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site