lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
On Fri, Sep 01, 2017 at 07:26:22AM -0700, Guenter Roeck wrote:
> On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote:
> > Document the devicetree bindings for the ltq-cputemp
> >
> > Signed-off-by: Florian Eckert <fe@dev.tdt.de>
>
> I see nothing special with the bindings, and they are in line with other lantiq
> bindings, so I am taking the risk of accepting this patch (and the matching
> driver) without waiting for explicit approval from Rob. Rob, scream at me if
> that is not ok.

Perhaps the existing one was not well reviewed.

>
> Thanks,
> Guenter
>
> > ---
> > Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> > new file mode 100644
> > index 000000000000..33fd00a987c7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> > @@ -0,0 +1,10 @@
> > +Lantiq cpu temperatur sensor

s/temperatur/temperature/

> > +
> > +Requires node properties:
> > +- compatible value :
> > + "lantiq,cputemp"

Kind of non-specific. How is this device even accessed without any other
property?

> > +
> > +Example:
> > + cputemp@0 {

unit-address without reg property is not valid.

> > + compatible = "lantiq,cputemp";
> > + };
> > --
> > 2.11.0
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html

\
 
 \ /
  Last update: 2017-09-12 18:20    [W:0.063 / U:2.784 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site