lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 11/13] xen/pvcalls: implement poll command
From
Date

>>> +
>>> +unsigned int pvcalls_front_poll(struct file *file, struct socket *sock,
>>> + poll_table *wait)
>>> +{
>>> + struct pvcalls_bedata *bedata;
>>> + struct sock_mapping *map;
>>> +
>>> + if (!pvcalls_front_dev)
>>> + return POLLNVAL;
>>> + bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
>>> +
>>> + map = (struct sock_mapping *) READ_ONCE(sock->sk->sk_send_head);
>> I just noticed this --- why is it READ_ONCE? Are you concerned that
>> sk_send_head may change?
> No, but I wanted to avoid partial reads. A caller could call
> pvcalls_front_accept and pvcalls_front_poll on newsock almost at the
> same time (it is probably not the correct way to use the API), I wanted
> to make sure that "map" is either read correctly, or not read at all.

How can you have a partial read on a pointer?

-boris

\
 
 \ /
  Last update: 2017-09-12 16:15    [W:0.352 / U:0.164 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site