lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unnecessary spaces


On Tue, 12 Sep 2017, Harsha Sharma wrote:

> Space between function name and open parentheses '(' is prohibited.
> Space is required around most binary operators '=', '==', '+=',
> '<', ':', '+', '-'
> Space required before '&', '*'
> Space is required after ',', ';'
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 30 +++++++++++++--------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> index 80ca2d7..49cb701 100644
> --- a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> @@ -19,7 +19,7 @@
> #include <drv_types.h>
> #include <rtw_debug.h>
>
> -static void _dynamic_check_timer_handlder (void *FunctionContext)
> +static void _dynamic_check_timer_handlder(void *FunctionContext)
> {
> struct adapter *adapter = FunctionContext;
>
> @@ -51,8 +51,8 @@ void rtw_os_indicate_connect(struct adapter *adapter)
> {
> struct mlme_priv *pmlmepriv = &(adapter->mlmepriv);
>
> - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) ==true) ||
> - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) ==true))
> + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) ||
> + (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true))
> {
> rtw_cfg80211_ibss_indicate_connect(adapter);
> }
> @@ -99,7 +99,7 @@ void rtw_reset_securitypriv(struct adapter *adapter)
> /* reset RX BIP packet number */
> pmlmeext->mgnt_80211w_IPN_rx = 0;
>
> - memset((unsigned char *)&adapter->securitypriv, 0, sizeof (struct security_priv));
> + memset((unsigned char *)&adapter->securitypriv, 0, sizeof(struct security_priv));
>
> /* Added by Albert 2009/02/18 */
> /* Restore the PMK information to securitypriv structure for the following connection. */
> @@ -116,9 +116,9 @@ void rtw_reset_securitypriv(struct adapter *adapter)
> {
> /* if (adapter->mlmepriv.fw_state & WIFI_STATION_STATE) */
> /* */
> - struct security_priv *psec_priv =&adapter->securitypriv;
> + struct security_priv *psec_priv = &adapter->securitypriv;
>
> - psec_priv->dot11AuthAlgrthm =dot11AuthAlgrthm_Open; /* open system */
> + psec_priv->dot11AuthAlgrthm = dot11AuthAlgrthm_Open; /* open system */
> psec_priv->dot11PrivacyAlgrthm = _NO_PRIVACY_;
> psec_priv->dot11PrivacyKeyIndex = 0;
>
> @@ -150,7 +150,7 @@ void rtw_os_indicate_disconnect(struct adapter *adapter)
> void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *sec_ie)
> {
> uint len;
> - u8 *buff,*p, i;
> + u8 *buff, *p, i;
> union iwreq_data wrqu;
>
> RT_TRACE(_module_mlme_osdep_c_, _drv_info_, ("+rtw_report_sec_ie, authmode =%d\n", authmode));
> @@ -168,22 +168,22 @@ void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *sec_ie)
> }
> p = buff;
>
> - p+=sprintf(p,"ASSOCINFO(ReqIEs =");
> + p += sprintf(p, "ASSOCINFO(ReqIEs =");
>
> - len = sec_ie[1]+2;
> - len = (len < IW_CUSTOM_MAX) ? len:IW_CUSTOM_MAX;
> + len = sec_ie[1] + 2;
> + len = (len < IW_CUSTOM_MAX) ? len : IW_CUSTOM_MAX;
>
> - for (i = 0;i<len;i++) {
> - p+=sprintf(p,"%02x", sec_ie[i]);
> + for (i = 0; i < len; i++) {
> + p += sprintf(p, "%02x", sec_ie[i]);
> }
>
> - p+=sprintf(p,")");
> + p += sprintf(p, ")");
>
> memset(&wrqu, 0, sizeof(wrqu));
>
> - wrqu.data.length =p-buff;
> + wrqu.data.length = p - buff;
>
> - wrqu.data.length = (wrqu.data.length<IW_CUSTOM_MAX) ? wrqu.data.length:IW_CUSTOM_MAX;
> + wrqu.data.length = (wrqu.data.length < IW_CUSTOM_MAX) ? wrqu.data.length : IW_CUSTOM_MAX;
>
> kfree(buff);
> }
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505221926-2865-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

\
 
 \ /
  Last update: 2017-09-12 15:26    [W:0.052 / U:0.868 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site