lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages
On Wed 2017-09-06 22:27:47, Helge Deller wrote:
> This patch series fixes the wrong usages of the %pF and %pS printk format
> specifiers throughout the kernel code.
>
> Both specifiers have the same result on most architectures. But on ia64, ppc64
> and parisc64 architectures the %pF specifier does an extra conversion because
> there function pointers are actually function descriptors.
>
> Helge
>
> Helge Deller (14):
> arm: Use %pS printk format for symbols from direct addresses
> um: Use %pS printk format for symbols from direct addresses

IMHO, we should use %pB in this patch.

> x86: Use %pS printk format for symbols from direct addresses
> ti_sci: Use %pS printk format for direct addresses
> i915: Use %pS printk format for direct addresses
> md/bcache: Use %pS printk format for direct addresses
> power/avs: Use %pS printk format for direct addresses
> fs/f2fs: Use %pS printk format for direct addresses
> fs/pstore: Use %pS printk format for direct addresses
> fs/xfs: Use %pS printk format for direct addresses
> smp: Use %pF printk format specifier for function pointers
> mm/memblock: Use %pS printk format for direct addresses
> netfilter/ipvs: Use %pS printk format for direct addresses
> sound/core: Use %pS printk format for direct addresses

All other patches look fine. For the entire patchset, except
for the "um: " patch, feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Let me known if this is enough or if I should answer each patch
individually.

Best Regards,
Petr

\
 
 \ /
  Last update: 2017-09-12 14:23    [W:0.303 / U:8.152 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site