lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table
On Mon, Sep 11, 2017 at 10:47:50AM -0600, Jason Gunthorpe wrote:
> On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote:
>
> > chip->bin_log_seqops.chip = chip;
> > - if (chip->flags & TPM_CHIP_FLAG_TPM2)
> > +
> > + if (log_version == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 ||
> > + (!log_version && (chip->flags & TPM_CHIP_FLAG_TPM2)))
> > chip->bin_log_seqops.seqops =
> > &tpm2_binary_b_measurements_seqops;
>
> Lets have all the read_log_* versions return the postitive log_version
> and get rid of the chip->flags check here.
>
> ie Doesn't ACPI always return the TPM 1 version?

That is my understanding. Ashley, Nayna, could you confirm the format
version expected by tpm_of? Could it be both?

>
> Jason

\
 
 \ /
  Last update: 2017-09-12 10:50    [W:0.074 / U:8.068 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site