Messages in this thread | | | Date | Tue, 12 Sep 2017 10:48:51 +0200 | From | Thiebaud Weksteen <> | Subject | Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table |
| |
On Mon, Sep 11, 2017 at 10:47:50AM -0600, Jason Gunthorpe wrote: > On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote: > > > chip->bin_log_seqops.chip = chip; > > - if (chip->flags & TPM_CHIP_FLAG_TPM2) > > + > > + if (log_version == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 || > > + (!log_version && (chip->flags & TPM_CHIP_FLAG_TPM2))) > > chip->bin_log_seqops.seqops = > > &tpm2_binary_b_measurements_seqops; > > Lets have all the read_log_* versions return the postitive log_version > and get rid of the chip->flags check here. > > ie Doesn't ACPI always return the TPM 1 version?
That is my understanding. Ashley, Nayna, could you confirm the format version expected by tpm_of? Could it be both?
> > Jason
| |