lkml.org 
[lkml]   [2017]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] csi: libcxgbi: remove redundant check and close on csk
On Thu, Sep 07, 2017 at 02:51:33PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> csk is always null on the error return path and so the non-null
> check and call to cxgbi_sock_closed on csk is redundant and
> can be removed.
>
> Detected by: CoverityScan CID#114329 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index 512c8f1ea5b0..da36c2de069e 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -688,8 +688,6 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex)
>
> rel_rt:
> ip_rt_put(rt);
> - if (csk)
> - cxgbi_sock_closed(csk);
> err_out:
> return ERR_PTR(err);
> }

Acked-by: Varun Prakash <varun@chelsio.com>

\
 
 \ /
  Last update: 2017-09-11 11:22    [W:0.055 / U:0.996 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site