lkml.org 
[lkml]   [2017]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard commands
From
Date
On 2017/9/12 9:53, Chao Yu wrote:
> On 2017/9/11 11:38, Jaegeuk Kim wrote:
>> If issue_cond is true, it does double count for # of issued commands.
>>
>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>

As Daeho Jeong mentioned, the change makes 'iter > DISCARD_ISSUE_RATE' dead
code, I just misread iter and issued variable, sorry. :(

Thanks,

>
>> ---
>> fs/f2fs/segment.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 7fd742f747ce..25196ff5d587 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -1087,7 +1087,7 @@ static int __issue_discard_cmd(struct f2fs_sb_info *sbi, bool issue_cond)
>> issued++;
>> __submit_discard_cmd(sbi, dc);
>> }
>> - if (issue_cond && iter++ > DISCARD_ISSUE_RATE)
>> + if (issue_cond && iter > DISCARD_ISSUE_RATE)
>> goto out;
>> }
>> if (list_empty(pend_list) && dcc->pend_list_tag[i] & P_TRIM)
>>
>
>
>

\
 
 \ /
  Last update: 2017-09-12 05:53    [W:0.078 / U:1.876 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site