[lkml]   [2017]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip
On Mon, 11 Sep 2017, Vlastimil Babka wrote:

> > A follow-up change will set the pageblock skip for this memory since it is
> > never useful for either scanner.
> > """
> >
> >> Also there's now a danger that in cases where there's no direct
> >> compaction happening (just kcompactd), nothing will ever call
> >> __reset_isolation_suitable().
> >>
> >
> > I'm not sure that is helpful in a context where no high-order memory can
> > call direct compaction that kcompactd needlessly scanning the same memory
> > over and over is beneficial.
> The point is that if it becomes beneficial again, we won't know as there
> will be still be skip bits.

Why is kcompactd_do_work() not sometimes doing
__reset_isolation_suitable() in the first place, if only to reset the
per-zone migration and freeing scanner cached pfns? It seems fragile to
rely on other threads doing direct compaction to reset the per-zone state
of compaction.

 \ /
  Last update: 2017-09-11 23:14    [W:0.058 / U:5.980 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site