lkml.org 
[lkml]   [2017]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: support running perf binaries with a dash in their name
Em Mon, Sep 11, 2017 at 07:08:18AM -0700, David Ahern escreveu:
> On 9/11/17 4:14 AM, Milian Wolff wrote:
> > Previously the part behind "perf-" was interpreted as an internal
> > perf command. If the suffix could not be handled, the execution
<SNIP>
> > --- a/tools/perf/perf.c
> > - fprintf(stderr, "cannot handle %s internally", cmd);
> > - goto out;
> > + // if the command is handled, the above function does not return
> > + // undo changes and fall through in such a case

> Those should be /* */ not //
>
> > + cmd -= 5;
> > + argv[0] = cmd;
> > }
> > if (strstarts(cmd, "trace")) {
> > #ifdef HAVE_LIBAUDIT_SUPPORT

> other than that LGTM and long over due.

> Acked-by: David Ahern <dsahern@gmail.com>

We got those from git, agreed it should go, thanks for the Acked-by,
always welcome!

- Arnaldo

\
 
 \ /
  Last update: 2017-09-11 16:34    [W:0.048 / U:2.164 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site