lkml.org 
[lkml]   [2017]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sysrq : fix Show Regs call trace on ARM
From
Date
Hi,Jiri:

get_irq_regs() in the softirq context return NULL.

thanks,
Jibin Xu

On 2017年09月11日 13:24, Jiri Slaby wrote:
> On 09/11/2017, 05:11 AM, Jibin Xu wrote:
> ...
>> --- a/drivers/tty/sysrq.c
>> +++ b/drivers/tty/sysrq.c
>> @@ -245,8 +245,10 @@ static void sysrq_handle_showallcpus(int key)
>> * architecture has no support for it:
>> */
>> if (!trigger_all_cpu_backtrace()) {
>> - struct pt_regs *regs = get_irq_regs();
>> + struct pt_regs *regs = NULL;
>>
>> + if (in_irq())
>> + regs = get_irq_regs();
> Maybe a stupid question: how does get_irq_regs() behave in the softirq
> context? I.e. what about s/in_irq/in_interrupt/?
>
> thanks,

\
 
 \ /
  Last update: 2017-09-11 11:56    [W:0.083 / U:1.380 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site