lkml.org 
[lkml]   [2017]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] test_bitmap: Use ULL suffix for 64-bit constants
On Sun, Sep 10, 2017 at 12:48:43PM +0200, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
>
> lib/test_bitmap.c:189: warning: integer constant is too large for ‘long’ type
> lib/test_bitmap.c:190: warning: integer constant is too large for ‘long’ type
> lib/test_bitmap.c:194: warning: integer constant is too large for ‘long’ type
> lib/test_bitmap.c:195: warning: integer constant is too large for ‘long’ type
>
> Add the missing "ULL" suffix to fix this.
>
> Fixes: 60ef690018b262dd ("bitmap: introduce BITMAP_FROM_U64()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks.
Acked-by: Yury Norov <ynorov@caviumnetworks.com>

> ---
> lib/test_bitmap.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 599c6713f2a2aaa8..aa1f2669bdd5d836 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -186,13 +186,13 @@ static const unsigned long exp[] __initconst = {
> BITMAP_FROM_U64(0x22222222),
> BITMAP_FROM_U64(0xffffffff),
> BITMAP_FROM_U64(0xfffffffe),
> - BITMAP_FROM_U64(0x3333333311111111),
> - BITMAP_FROM_U64(0xffffffff77777777)
> + BITMAP_FROM_U64(0x3333333311111111ULL),
> + BITMAP_FROM_U64(0xffffffff77777777ULL)
> };
>
> static const unsigned long exp2[] __initconst = {
> - BITMAP_FROM_U64(0x3333333311111111),
> - BITMAP_FROM_U64(0xffffffff77777777)
> + BITMAP_FROM_U64(0x3333333311111111ULL),
> + BITMAP_FROM_U64(0xffffffff77777777ULL)
> };
>
> static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> --
> 2.7.4

\
 
 \ /
  Last update: 2017-09-10 15:34    [W:0.061 / U:0.916 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site