lkml.org 
[lkml]   [2017]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] extcon: make extcon_info static const, fixes warning
On 2017년 09월 10일 01:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array extcon_info is read only, local to the source and does not
> need to be in global scope, so make it static const.
>
> Cleans up sparse warning:
> symbol 'extcon_info' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/extcon/extcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 35e9fb885486..cb38c2747684 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -36,7 +36,7 @@
>
> #define SUPPORTED_CABLE_MAX 32
>
> -struct __extcon_info {
> +static const struct __extcon_info {
> unsigned int type;
> unsigned int id;
> const char *name;
>

Applied it for v4.15. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics

\
 
 \ /
  Last update: 2017-09-11 02:43    [W:0.033 / U:2.220 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site