[lkml]   [2017]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: iov_iter_pipe warning.
On Mon, Sep 11, 2017 at 12:07:23AM +0100, Al Viro wrote:

> BTW, another problem I see there is that iomap_dio_actor() should *NOT*
> assume that do-while loop in there will always manage to shove 'length'
> bytes out in case of success. That is simply not true for pipe-backed
> destination. And I'm not sure if outright failures halfway through
> are handled correctly. What does it need a copy of dio->submit.iter for,
> anyway? Why not work with dio->submit.iter directly?

I mean, if it's just a matter of iov_iter_truncate() to be undone in
the end, that's not hard to do - iov_iter_reexpand() is there. Or is there
something more subtle in the play?

 \ /
  Last update: 2017-09-11 01:16    [W:0.052 / U:22.440 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site