lkml.org 
[lkml]   [2017]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes
On Fri, Sep 08, 2017 at 03:39:04PM +0800, Chen-Yu Tsai wrote:
> On Fri, Sep 8, 2017 at 3:36 PM, Corentin Labbe
> <clabbe.montjoie@gmail.com> wrote:
> > On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote:
> >> On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote:
> >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> >> > index 1c2387bd5df6..968908761194 100644
> >> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> >> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> >> > @@ -50,6 +50,7 @@
> >> > compatible = "friendlyarm,nanopi-neo2", "allwinner,sun50i-h5";
> >> >
> >> > aliases {
> >> > + ethernet0 = &emac;
> >> > serial0 = &uart0;
> >> > };
> >> >
> >> > @@ -108,6 +109,22 @@
> >> > status = "okay";
> >> > };
> >> >
> >> > +&emac {
> >> > + pinctrl-names = "default";
> >> > + pinctrl-0 = <&emac_rgmii_pins>;
> >> > + phy-supply = <&reg_gmac_3v3>;
> >> > + phy-handle = <&ext_rgmii_phy>;
> >> > + phy-mode = "rgmii";
> >> > + status = "okay";
> >> > +};
> >> > +
> >> > +&mdio {
> >> > + ext_rgmii_phy: ethernet-phy@7 {
> >> > + compatible = "ethernet-phy-ieee802.3-c22";
> >> > + reg = <7>;
> >> > + };
> >> > +};
> >> > +
> >>
> >> This won't compile, you don't have that node in the H5 DTSI.
> >>
> >
> > Since H5 DTSI include arm/sunxi-h3-h5.dtsi it compiles.
> > Furthermore, I restested just now and confirm, it compiles fine.
>
> The order of your patches are wrong. No individual patch should
> introduce build failures, not just the whole patch series.
>

Yes, I just miss-understood the reason of build failure.
I will fix the order in the next serie.

Thanks
Corentin Labbe

\
 
 \ /
  Last update: 2017-09-10 20:57    [W:0.066 / U:0.812 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site