lkml.org 
[lkml]   [2017]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: Fix ignoring cover-letter logic
From
Date
On Sat, 2017-09-09 at 18:04 +0900, Stafford Horne wrote:
> Currently running checkpatch on a directory with a cover-letter.patch
> file reports the following error:
>
> -----------------------------------------
> patches/smp-v2/v2-0000-cover-letter.patch
> -----------------------------------------
>
> ERROR: Does not appear to be a unified-diff format patch
>
> The logic to suppress the unified-diff check for cover letters is there
> but is checking $file instead of $filename. Fix the variable to use the
> correct one.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Acked-by: Joe Perches <joe@perches.com>

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6365,7 +6365,7 @@ sub process {
> exit(0);
> }
>
> - if (!$is_patch && $file !~ /cover-letter\.patch$/) {
> + if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
> ERROR("NOT_UNIFIED_DIFF",
> "Does not appear to be a unified-diff format patch\n");
> }

\
 
 \ /
  Last update: 2017-09-10 20:08    [W:0.031 / U:5.904 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site