lkml.org 
[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking
Date
>-----Original Message-----
>From: Mark Brown [mailto:broonie@kernel.org]
>Sent: Thursday, August 31, 2017 4:44 AM
>To: Ryan Lee <RyanS.Lee@maximintegrated.com>
>Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com;
>kuninori.morimoto.gx@renesas.com; alsa-devel@alsa-project.org; linux-
>kernel@vger.kernel.org; ryan.lee.maxim@gmail.com
>Subject: Re: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking
>
>On Mon, Aug 28, 2017 at 04:30:54PM -0700, Ryan Lee wrote:
>
>> /* Envelope Tracking configuration */
>> regmap_write(max98927->regmap,
>> MAX98927_R0082_ENV_TRACK_VOUT_HEADROOM,
>> - 0x08);
>> + 0x0A);
>> regmap_write(max98927->regmap,
>> MAX98927_R0086_ENV_TRACK_CTRL,
>> 0x01);
>> - regmap_write(max98927->regmap,
>> - MAX98927_R0087_ENV_TRACK_BOOST_VOUT_READ,
>> - 0x10);
>
>Why are we changing the defaults here? It was understandable to have a fixed
>default that differed from the chip value when there was no control but now
>there is a control and we're changing the default again for some undocumented
>reason. It'd be better to leave the values here to avoid breaking compatibility
>with existing users and let users who need different values change things using
>the newly added controls.

Thank you for feedback. Let me keep existing value.
I still need to remove regmap_write for R:0x87 because it is read-only register.

\
 
 \ /
  Last update: 2017-09-01 23:39    [W:0.056 / U:4.520 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site