[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking
>-----Original Message-----
>From: Mark Brown []
>Sent: Thursday, August 31, 2017 4:44 AM
>To: Ryan Lee <>
>;; linux-
>Subject: Re: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking
>On Mon, Aug 28, 2017 at 04:30:54PM -0700, Ryan Lee wrote:
>> /* Envelope Tracking configuration */
>> regmap_write(max98927->regmap,
>> - 0x08);
>> + 0x0A);
>> regmap_write(max98927->regmap,
>> MAX98927_R0086_ENV_TRACK_CTRL,
>> 0x01);
>> - regmap_write(max98927->regmap,
>> - 0x10);
>Why are we changing the defaults here? It was understandable to have a fixed
>default that differed from the chip value when there was no control but now
>there is a control and we're changing the default again for some undocumented
>reason. It'd be better to leave the values here to avoid breaking compatibility
>with existing users and let users who need different values change things using
>the newly added controls.

Thank you for feedback. Let me keep existing value.
I still need to remove regmap_write for R:0x87 because it is read-only register.

 \ /
  Last update: 2017-09-01 23:39    [W:0.181 / U:0.196 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site