lkml.org 
[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] perf: Rewrite enabled/running timekeeping
On Thu, 31 Aug 2017, Peter Zijlstra wrote:

> So the below completely rewrites timekeeping (and probably breaks
> world) but does away with the need to touch events that don't get
> scheduled.
>
> Esp the cgroup stuff is entirely untested since I simply don't know how
> to operate that. I did run Vince's tests on it, and I think it doesn't
> regress, but I'm near a migraine so I can't really see straight atm.
>
> Vince, Stephane, could you guys have a peek?

I have to admit that I *always* got lost trying to figure out the old
so I might not be the best person to review the changes.

I did try running the perf_event_tests on a few machines and they all pass.

I also ran the PAPI tests and a few of the multiplexing tests fail about
10% of the time but I think they also fail 10% of the time with the old
code too. I need to figure out why that's happening but it's likely a
PAPI issue not a kernel one.

Vince


\
 
 \ /
  Last update: 2017-09-01 23:22    [W:0.132 / U:4.308 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site