lkml.org 
[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy_desc static
On Fri, Sep 01, 2017 at 11:20:57AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The const structure fusb302_psy_desc is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warnings
> symbol 'fusb302_psy_desc' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/staging/typec/fusb302/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index cf6355f59cd9..fc6a3cf74eb3 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1723,7 +1723,7 @@ static enum power_supply_property fusb302_psy_properties[] = {
> POWER_SUPPLY_PROP_CURRENT_MAX,
> };
>
> -const struct power_supply_desc fusb302_psy_desc = {
> +static const struct power_supply_desc fusb302_psy_desc = {
> .name = "fusb302-typec-source",
> .type = POWER_SUPPLY_TYPE_USB_TYPE_C,
> .properties = fusb302_psy_properties,
> --
> 2.14.1
>

\
 
 \ /
  Last update: 2017-09-01 16:21    [W:0.042 / U:0.432 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site