lkml.org 
[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] DSA support for Micrel KSZ8895
    Hi!

    On Wed 2017-08-30 21:32:07, Tristram.Ha@microchip.com wrote:
    > > On Mon 2017-08-28 16:09:27, Andrew Lunn wrote:
    > > > > I may be confused here, but AFAICT:
    > > > >
    > > > > 1) Yes, it has standard layout when accessed over MDIO.
    > > >
    > > >
    > > > Section 4.8 of the datasheet says:
    > > >
    > > > All the registers defined in this section can be also accessed
    > > > via the SPI interface.
    > > >
    > > > Meaning all PHY registers can be access via the SPI interface. So you
    > > > should be able to make a standard Linux MDIO bus driver which performs
    > > > SPI reads.
    > >
    > > As far as I can tell (and their driver confirms) -- yes, all those registers can be
    > > accessed over the SPI, they are just shuffled around... hence MDIO
    > > emulation code. I copied it from their code (see the copyrights) so no, I don't
    > > believe there's nicer solution.
    > >
    > > Best regards,
    >
    > Can you hold on your developing work on KSZ8895 driver? I am afraid your effort may be in vain. We at Microchip are planning to release DSA drivers for all KSZ switches, starting at KSZ8795, then KSZ8895, and KSZ8863.
    >

    Well, thanks for heads up... but its too late to stop now. I already
    have working code, without the advanced features.

    I don't know how far away you are with the development. You may want
    to start from my driver (but its probably too late now).

    > The driver files all follow the structures of the current KSZ9477 DSA driver, and the file tag_ksz.c will be updated to handle the tail tag of different chips, which requires including the ksz_priv.h header. That is required nevertheless to support using the offload_fwd_mark indication.
    >
    > The KSZ8795 driver will be submitted after Labor Day (9/4) if
    > testing reveals no problem. The KSZ8895 driver will be submitted
    > right after that. You should have no problem using the driver right
    > away.

    Well, normally world can help with the testing, too. It would be nice
    to see the code, as [RFC]. There's great chance that you'll have to
    modify the code to adress review feedback, which is why seeing code
    soon is useful.

    Best regards,
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-09-01 14:16    [W:4.190 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site