lkml.org 
[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/16] fs: fix kernel_read prototype
On Wed, Aug 30, 2017 at 04:37:04PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:56PM +0200, Christoph Hellwig wrote:
> > Use proper ssize_t and size_t types for the return value and count
> > argument, move the offset last and make it an in/out argument like
> > all other read/write helpers.
>
> Might be better to switch the third argument to void * at the same time
> and lose those casts.

Good point, updated.

>
> > if (p)
> > memcpy(p + offset, buf, n);
> > -
> > - offset += n;
>
> Almost certainly broken - in effect, you've taken the update of offset
> several lines prior, so that memcpy() is getting the wrong first argument.
> The same needs to be watched out for in other similar places.

Fixed. I did an audit and didn't find any others either for kernel_read
or kernel_write.

\
 
 \ /
  Last update: 2017-09-01 12:37    [W:1.957 / U:1.148 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site