Messages in this thread | | | Subject | Re: [PATCH] powerpc: xive: ensure active irqd when setting affinity | From | Benjamin Herrenschmidt <> | Date | Wed, 09 Aug 2017 17:33:59 +1000 |
| |
On Wed, 2017-08-09 at 16:15 +1000, Michael Ellerman wrote: > I'm not sure I'm convinced. We can't handle every possible case of the > higher level code calling us in situations we don't expect. > > For example irq_data could be NULL, but we trust the higher level code > not to do that to us. > > Also I don't see any other driver doing this check. > > $ git grep irqd_is_started > include/linux/irq.h:static inline bool irqd_is_started(struct irq_data *d) > kernel/irq/chip.c: if (irqd_is_started(d)) { > kernel/irq/chip.c: if (irqd_is_started(&desc->irq_data)) { > kernel/irq/cpuhotplug.c: if (irqd_is_per_cpu(d) || !irqd_is_started(d) || !irq_needs_fixup(d)) {
irqd_is_started is brand new so you won't find any :-)
For most cases the problem is a non-issue. Due to how xive works, it's more of a problem for us because a non-started interrupt has no targetting information at all.
So this is *somewhat* related to xive internal and I'd rather have that sanity check in there.
Cheers, Ben.
| |