lkml.org 
[lkml]   [2017]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 9/9] ACPI-video: Improve a size determination in four functions
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 9 Aug 2017 16:45:29 +0200

    Replace the specification of a data structures by variable references
    as the parameter for the operator "sizeof" to make the corresponding size
    determination a bit safer according to the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/acpi/acpi_video.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
    index 3cc1798676ab..d999f4e49b98 100644
    --- a/drivers/acpi/acpi_video.c
    +++ b/drivers/acpi/acpi_video.c
    @@ -1140,7 +1140,7 @@ acpi_video_bus_get_one_device(struct acpi_device *device,
    if (ACPI_FAILURE(status))
    return 0;

    - data = kzalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
    + data = kzalloc(sizeof(*data), GFP_KERNEL);
    if (!data)
    return -ENOMEM;

    @@ -1321,7 +1321,7 @@ static int acpi_video_device_enumerate(struct acpi_video_bus *video)
    dod->package.count));

    active_list = kcalloc(1 + dod->package.count,
    - sizeof(struct acpi_video_enumerated_device),
    + sizeof(*active_list),
    GFP_KERNEL);
    if (!active_list) {
    status = -ENOMEM;
    @@ -1742,7 +1742,7 @@ static void acpi_video_dev_register_backlight(struct acpi_video_device *device)
    pci_dev_put(pdev);
    }

    - memset(&props, 0, sizeof(struct backlight_properties));
    + memset(&props, 0, sizeof(props));
    props.type = BACKLIGHT_FIRMWARE;
    props.max_brightness =
    device->brightness->count - ACPI_VIDEO_FIRST_LEVEL - 1;
    @@ -2007,7 +2007,7 @@ static int acpi_video_bus_add(struct acpi_device *device)
    return -ENODEV;
    }

    - video = kzalloc(sizeof(struct acpi_video_bus), GFP_KERNEL);
    + video = kzalloc(sizeof(*video), GFP_KERNEL);
    if (!video)
    return -ENOMEM;

    --
    2.13.4
    \
     
     \ /
      Last update: 2017-08-09 17:48    [W:4.735 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site