Messages in this thread | | | Subject | Re: [PATCH 1/2] mfd: intel_soc_pmic_chtwc: Remove unneeded I2C device ID table | From | Hans de Goede <> | Date | Wed, 9 Aug 2017 14:01:09 +0200 |
| |
Hi,
On 09-08-17 10:44, Javier Martinez Canillas wrote: > The driver has an empty I2C device table as a workaround for a previous > bug in the I2C core that was returning -ENODEV in i2c_device_probe() if > the driver didn't have an I2C device ID table. Even when is for an ACPI > only device and so the driver shouldn't need an I2C ID table in theory. > > But now this issue has been fixed by commit c64ffff7a9d1 ("i2c: core: > Allow empty id_table in ACPI case as well"), so the empty I2C device > ID table can be removed. > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Thank you. Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > > drivers/mfd/intel_soc_pmic_chtwc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c b/drivers/mfd/intel_soc_pmic_chtwc.c > index b35da01d5bcf..ca01ecd1e546 100644 > --- a/drivers/mfd/intel_soc_pmic_chtwc.c > +++ b/drivers/mfd/intel_soc_pmic_chtwc.c > @@ -208,10 +208,6 @@ static int __maybe_unused cht_wc_resume(struct device *dev) > } > static SIMPLE_DEV_PM_OPS(cht_wc_pm_ops, cht_wc_suspend, cht_wc_resume); > > -static const struct i2c_device_id cht_wc_i2c_id[] = { > - { } > -}; > - > static const struct acpi_device_id cht_wc_acpi_ids[] = { > { "INT34D3", }, > { } > @@ -225,6 +221,5 @@ static struct i2c_driver cht_wc_driver = { > }, > .probe_new = cht_wc_probe, > .shutdown = cht_wc_shutdown, > - .id_table = cht_wc_i2c_id, > }; > builtin_i2c_driver(cht_wc_driver); >
| |