Messages in this thread Patch in this message | | | From | Pan Bian <> | Subject | [V2] kexec_file: use crypto_free_shash to free memory | Date | Wed, 9 Aug 2017 19:30:01 +0800 |
| |
In function kexec_calculate_store_digests(), kfree() is used to free memory allocated by crypto_alloc_shash(). It is better to use function crypto_free_shash(), which frees up tfm and any resources associated with it. And then, the refcount of the algorithm used in crypto_alloc_shash() is also dropped.
Signed-off-by: Pan Bian <bianpan2016@163.com> --- kernel/kexec_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index 9f48f44..94eeb38 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -627,7 +627,7 @@ static int kexec_calculate_store_digests(struct kimage *image) out_free_desc: kfree(desc); out_free_tfm: - kfree(tfm); + crypto_free_shash(tfm); out: return ret; } -- 1.9.1
| |