lkml.org 
[lkml]   [2017]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost converter as regulator
    On Tue, Aug 8, 2017 at 2:00 AM, Hans de Goede <hdegoede@redhat.com> wrote:
    > Hi,
    >
    > On 08-08-17 10:39, Liam Breck wrote:
    >>
    >> Hi Hans,
    >>
    >> On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede <hdegoede@redhat.com> wrote:
    >>>
    >>> Register the 5V boost converter as a regulator named
    >>> "regulator-bq24190-usb-vbus". Note the name includes "bq24190" because
    >>> the bq24190 family is also used on ACPI devices where there are no
    >>> device-tree phandles, so regulator_get will fallback to the name and thus
    >>> it must be unique on the system.
    >>
    >>
    >> What we're enabling here is 5V boost for otg host mode, not vbus
    >> generally, so maybe the name should indicate that...
    >>
    >> regulator-bq24190-usb-5volt
    >> regulator-bq24190-usb-host
    >> regulator-bq24190-usb-otg-5v
    >
    >
    > I picked vbus because that gets used a lot already in similar cases,
    > but I agree that we should probably come up with a better name.
    >
    > I like "regulator-bq24190-usb-otg-5v", shall I use that for v2?

    There is this upstream, with "otg-vbus":
    https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=61274eff0ddee8f10deaa5f79085e981db52930a

    Related search:
    https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/?qt=grep&q=otg+regulator

    I don't think it needs a "regulator-" prefix, and maybe the driver
    name is a suffix. We could also recommend the "regulator-name" value
    for OTG here:
    https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/Documentation/devicetree/bindings/regulator/regulator.txt

    a. Make the above patch wrong :-)
    usb-otg-5v (generic)
    usb-otg-5v-bq2419x (specific)

    b. Follow a weak precedent
    otg-vbus (generic)
    otg-vbus-bq2419x (specific)

    \
     
     \ /
      Last update: 2017-08-08 20:58    [W:2.290 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site