lkml.org 
[lkml]   [2017]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
    Date
    On Tue 8/8/2017 6:05 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:

    > -----Original Message-----
    > From: Michael Ellerman [mailto:mpe@ellerman.id.au]
    > Sent: Tuesday, August 08, 2017 6:05 PM
    > To: Qiang Zhao <qiang.zhao@nxp.com>; tglx@linutronix.de
    > Cc: oss@buserror.net; linuxppc-dev@lists.ozlabs.org; Xiaobo Xie
    > <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org
    > Subject: RE: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
    >
    > Qiang Zhao <qiang.zhao@nxp.com> writes:
    >
    > > On Mon 8/7/2017 3:02 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
    > >
    > >> -----Original Message-----
    > >> From: Michael Ellerman [mailto:mpe@ellerman.id.au]
    > >> Sent: Monday, August 07, 2017 3:02 PM
    > >> To: Qiang Zhao <qiang.zhao@nxp.com>; tglx@linutronix.de
    > >> Cc: oss@buserror.net; Qiang Zhao <qiang.zhao@nxp.com>; linuxppc-
    > >> dev@lists.ozlabs.org; Xiaobo Xie <xiaobo.xie@nxp.com>; linux-
    > >> kernel@vger.kernel.org
    > >> Subject: Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
    > >>
    > >> Zhao Qiang <qiang.zhao@nxp.com> writes:
    > >>
    > >> > QEIC was supported on PowerPC, and dependent on PPC, Now it is
    > >> > supported on other platforms, so remove PPCisms.
    > >> >
    > >> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
    > >> > ---
    > >> > arch/powerpc/platforms/83xx/km83xx.c | 1 -
    > >> > arch/powerpc/platforms/83xx/misc.c | 1 -
    > >> > arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 -
    > >> > arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 -
    > >> > arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 -
    > >> > arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 -
    > >> > arch/powerpc/platforms/85xx/corenet_generic.c | 1 -
    > >> > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 -
    > >> > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 1 -
    > >> > arch/powerpc/platforms/85xx/twr_p102x.c | 1 -
    > >> > drivers/irqchip/irq-qeic.c | 188 +++++++++++---------------
    > >> > include/soc/fsl/qe/qe_ic.h | 132 ------------------
    > >> > 12 files changed, 80 insertions(+), 250 deletions(-) delete mode
    > >> > 100644 include/soc/fsl/qe/qe_ic.h
    > >> >
    > >> > diff --git a/arch/powerpc/platforms/83xx/km83xx.c
    > >> > b/arch/powerpc/platforms/83xx/km83xx.c
    > >> > index d8642a4..b1cef0a 100644
    > >> > --- a/arch/powerpc/platforms/83xx/km83xx.c
    > >> > +++ b/arch/powerpc/platforms/83xx/km83xx.c
    > >> > @@ -38,7 +38,6 @@
    > >> > #include <sysdev/fsl_soc.h>
    > >> > #include <sysdev/fsl_pci.h>
    > >> > #include <soc/fsl/qe/qe.h>
    > >> > -#include <soc/fsl/qe/qe_ic.h>
    > >>
    > >> You deleted that file in patch 2. So didn't you just break the build
    > >> for the last two commits?
    > >
    > > Sorry, I am not sure what you said. Could you explain?
    >
    > Don't worry about it. I was confused by the fact that we have both:
    >
    > drivers/soc/fsl/qe/qe_ic.h
    >
    > and:
    >
    > include/soc/fsl/qe/qe_ic.h
    >
    > cheers

    I think this is a issue left over by history.
    In patch with commit id 7aa1aa6ecec2af19d9aa85430ce3e56119e21626, I just move them out from arch/powerpc.
    Maybe need to ask the original author why there are 2 qe_ic.h.

    Best Regards
    Qiang Zhao

    \
     
     \ /
      Last update: 2017-08-09 04:36    [W:2.697 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site