lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Converting struct timer_list callback argument to struct timer_list *
On Thu, Aug 31, 2017 at 1:13 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 30 Aug 2017, Kees Cook wrote:
>> Which gets me to here:
>> 747 files changed, 3363 insertions(+), 3410 deletions(-)
>>
>> And current builds with the forced casts removed show about 400 more
>> call sites to fix...
>
> That's a herculean task. Chapeau!

Coccinelle has helped a lot, but yeah, not a small conversion! :P

>> Does this look alright,
>
> Very well done. I like the temporary typecast trick.

Okay, good. Since there's no sensible type checking here already, it
didn't seem _worse_. :)

>> and should some of this go into -next right
>> now, just to get some of the clean-ups into the tree? (Basically,
>> everything before "timer: Temporarily explicitly cast all callback
>> functions")
>
> Yes, just get that part in now.

Okay, I've sent the first 31 patches your way just now. I'll keep
grinding away at the rest...

-Kees

--
Kees Cook
Pixel Security

\
 
 \ /
  Last update: 2017-09-01 01:33    [W:0.080 / U:1.832 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site