lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] vt: Use bsearch library function in is_double_width
On Thu, Aug 31, 2017 at 05:02:53PM +0200, Greg KH wrote:
> On Thu, Aug 31, 2017 at 04:21:15PM +0200, Thomas Meyer wrote:
> > Use bsearch library function instead of duplicated functionality.
> >
One question: Having above changelog text and a nearly similar subject line is
fine for you?

> > v2: Re-introduce early exit from old binary search.
>
> That's not the difference from the previous patch...

It isn't?

v2 adds those lines:
+ if (ucs < double_width[0].first ||
+ ucs > double_width[ARRAY_SIZE(double_width) - 1].last)
+ return 0;

Which is the early exit from the old binary search, i.e. the current
implementation
What do you mean with "that's not the difference from the previous
patch"?

>
> And that info goes below the --- line, as the documentation states.

So besides adding v2 comment below the --- line, what else do you want
me to change to accept this patch?

\
 
 \ /
  Last update: 2017-09-01 01:29    [W:0.036 / U:3.064 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site