Messages in this thread | | | Subject | Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI | From | Benjamin Herrenschmidt <> | Date | Fri, 01 Sep 2017 07:14:10 +1000 |
| |
On Thu, 2017-08-31 at 08:24 -0700, Vernon Mauery wrote: > +int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid) > > +{ > > + return -ENOTTY; > > +} > > +int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid) > > +{ > > + return -ENOTTY; > > +} > > These should be static functions because they are defined in the header > file or you will get multiple symbol definitions.
static inline even or you'll get warning about them being unused iirc.
Cheers, Ben.
| |