lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Fix syntax in documentation of intel-pt config option
Em Thu, Aug 31, 2017 at 10:05:35AM +0200, Jack Henschel escreveu:
> As specified in tools/perf/Documentation/perf-config.txt, perf
> configuration items must be in 'key = value' format, otherwise the
> following error message occurs:
>
> $ perf record -e intel_pt//u -- ls
> bad config file line 2 in ~/.perfconfig
> $ cat .perfconfig
> [intel-pt]
> mispred-all
>
> Changing assigning a value to the key 'mispred-all' fixes the issue:
> $ perf record -e intel_pt//u -- ls
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Capured and wrote 0.031 MB perf.data]
> $ cat .perfconfig
> [intel-pt]
> mispred-all = true

You forgot to add your:

Signed-off-by: Jack Henschel <jackdev@mailbox.org>

I'm assuming you intended it, so I'm adding it to my local repository,
please ack this.

- Arnaldo

> ---
> tools/perf/Documentation/intel-pt.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/intel-pt.txt b/tools/perf/Documentation/intel-pt.txt
> index 4b6cdbf8f935..a47d845b9b61 100644
> --- a/tools/perf/Documentation/intel-pt.txt
> +++ b/tools/perf/Documentation/intel-pt.txt
> @@ -873,7 +873,7 @@ amended to take the number of elements as a parameter.
>
> $ cat ~/.perfconfig
> [intel-pt]
> - mispred-all
> + mispred-all = on
>
> $ perf record -e intel_pt//u ./sort 3000
> Bubble sorting array of 3000 elements
> --
> 2.14.1

\
 
 \ /
  Last update: 2017-08-31 18:34    [W:0.044 / U:9.864 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site