lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input: byd: make array seq static, reduces object code size
On Thu, Aug 31, 2017 at 01:47:30PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array seq on the stack, instead make it static.
> Makes the object code smaller by over 1100 bytes:
>
> Before:
> text data bss dec hex filename
> 6152 1216 64 7432 1d08 drivers/input/mouse/byd.o
>
> After:
> text data bss dec hex filename
> 4974 1280 64 6318 18ae drivers/input/mouse/byd.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thank you.

> ---
> drivers/input/mouse/byd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/byd.c b/drivers/input/mouse/byd.c
> index b27aa637f877..b64b81599f7e 100644
> --- a/drivers/input/mouse/byd.c
> +++ b/drivers/input/mouse/byd.c
> @@ -344,7 +344,7 @@ static int byd_reset_touchpad(struct psmouse *psmouse)
> u8 param[4];
> size_t i;
>
> - const struct {
> + static const struct {
> u16 command;
> u8 arg;
> } seq[] = {
> --
> 2.14.1
>

--
Dmitry

\
 
 \ /
  Last update: 2017-08-31 18:31    [W:0.036 / U:12.172 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site