lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:rtl8188eu:core Remove unneccessary else block
On Thu, Aug 31, 2017 at 05:03:30PM +0530, Janani Sankara Babu wrote:
> This patch is created to remove the unneccessary else statement inside the
> function 'SecIsInPMKIDList'.
>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index d3668ca..8480d30 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> @@ -1708,13 +1708,10 @@ static int SecIsInPMKIDList(struct adapter *Adapter, u8 *bssid)
>
> do {
> if ((psecuritypriv->PMKIDList[i].bUsed) &&
> - (!memcmp(psecuritypriv->PMKIDList[i].Bssid, bssid, ETH_ALEN))) {
> + (!memcmp(psecuritypriv->PMKIDList[i].Bssid, bssid, ETH_ALEN)))
> break;
> - } else {
> - i++;
> - /* continue; */
> - }
> -
> + i++;
> + /* continue; */

Delete the continue comment as well. It doesn't add anything.

> } while (i < NUM_PMKID_CACHE);

Or you could move the increment into the condition, but you'd have to
make it a pre-op:

} while (++i < NUM_PMKID_CACHE);

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-08-31 14:11    [W:0.029 / U:3.400 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site