[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking
On Mon, Aug 28, 2017 at 04:30:54PM -0700, Ryan Lee wrote:

> /* Envelope Tracking configuration */
> regmap_write(max98927->regmap,
> - 0x08);
> + 0x0A);
> regmap_write(max98927->regmap,
> MAX98927_R0086_ENV_TRACK_CTRL,
> 0x01);
> - regmap_write(max98927->regmap,
> - 0x10);

Why are we changing the defaults here? It was understandable to have a
fixed default that differed from the chip value when there was no
control but now there is a control and we're changing the default again
for some undocumented reason. It'd be better to leave the values here
to avoid breaking compatibility with existing users and let users who
need different values change things using the newly added controls.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2017-08-31 13:45    [W:0.230 / U:4.592 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site